Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities

[Akhil Goyal]

> +static const struct rte_cryptodev_capabilities *
> +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps)
> +{
> +     SEC_CAPS_ADD(hw_caps, aes);
> +
> +     sec_caps_add(caps_end, RTE_DIM(caps_end));
> +
> +     return otx2_cpt_sec_caps;
> +}
SEC_CAPS_ADD should be called earlier when the security context is created
Or where all other capabilities of the PMD are initialized.
It should not be added when capabilities need to be retrieved.
As of now you are supporting only AES-GCM, but in future if you add more algos,
Then it would be difficult to manage.