Hi Akhil,
Please see inline.
Thanks
Tejasree
> -----Original Message-----
> From: Akhil Goyal <akhil.go...@nxp.com>
> Sent: Thursday, July 2, 2020 2:37 AM
> To: Tejasree Kondoj <ktejas...@marvell.com>; Radu Nicolau
> <radu.nico...@intel.com>
> Cc: Narayana Prasad Raju Athreya <pathr...@marvell.com>; Anoob Joseph
> <ano...@marvell.com>; Vamsi Krishna Attunuru <vattun...@marvell.com>;
> dev@dpdk.org
> Subject: [EXT] RE: [PATCH 4/8] crypto/octeontx2: add cryptodev sec
> capabilities
>
> External Email
>
> ----------------------------------------------------------------------
> > +static const struct rte_cryptodev_capabilities *
> > +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps) {
> > + SEC_CAPS_ADD(hw_caps, aes);
> > +
> > + sec_caps_add(caps_end, RTE_DIM(caps_end));
> > +
> > + return otx2_cpt_sec_caps;
> > +}
> SEC_CAPS_ADD should be called earlier when the security context is created
> Or where all other capabilities of the PMD are initialized.
> It should not be added when capabilities need to be retrieved.
> As of now you are supporting only AES-GCM, but in future if you add more
> algos, Then it would be difficult to manage.
[Tejasree] We will initialize capabilities during probe and capabilities_get()
would return pointer. Would that work?
