Hi Akhil, Please see inline.
Thanks, Anoob > -----Original Message----- > From: Akhil Goyal <akhil.go...@nxp.com> > Sent: Thursday, July 2, 2020 2:17 AM > To: Tejasree Kondoj <ktejas...@marvell.com>; Radu Nicolau > <radu.nico...@intel.com> > Cc: Narayana Prasad Raju Athreya <pathr...@marvell.com>; Anoob Joseph > <ano...@marvell.com>; Vamsi Krishna Attunuru <vattun...@marvell.com>; > dev@dpdk.org > Subject: [EXT] RE: [PATCH 2/8] crypto/octeontx2: add lookaside SA context > definitions > > External Email > > ---------------------------------------------------------------------- > > > Subject: [PATCH 2/8] crypto/octeontx2: add lookaside SA context > definitions > > > > Signed-off-by: Vamsi Attunuru <vattun...@marvell.com> > > Signed-off-by: Tejasree Kondoj <ktejas...@marvell.com> > > --- > Please add appropriate description in all the patches. > > > drivers/crypto/octeontx2/otx2_cryptodev_sec.h | 52 ++++++++ > > drivers/crypto/octeontx2/otx2_ipsec_po.h | 119 > ++++++++++++++++++ > > drivers/crypto/octeontx2/otx2_security.h | 2 + > > drivers/net/octeontx2/otx2_ethdev_sec.h | 1 + > > 4 files changed, 174 insertions(+) > > create mode 100644 drivers/crypto/octeontx2/otx2_cryptodev_sec.h > > create mode 100644 drivers/crypto/octeontx2/otx2_ipsec_po.h > > > > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.h > > b/drivers/crypto/octeontx2/otx2_cryptodev_sec.h > > new file mode 100644 > > index 0000000000..af62207d07 > > --- /dev/null > > +++ b/drivers/crypto/octeontx2/otx2_cryptodev_sec.h > > @@ -0,0 +1,52 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright (C) 2020 Marvell International Ltd. > > + */ > > + > > +#ifndef __OTX2_CRYPTODEV_SEC_H__ > > +#define __OTX2_CRYPTODEV_SEC_H__ > > + > > +#include "otx2_ipsec_po.h" > Why is it named like this? What is 'po' ? [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for inline and one for lookaside. The one for inline is FP and the one for lookaside is PO (Protocol Offload).
