On 07/05/2020 08:37, Ophir Munk wrote: > Move mlx5 symbols in the map file to the INTERNAL section and add > __internal tags to their definitions. > Those symbols were exported in 20.02 and now (20.05) they are removed. > Avoid ABI comparison issues between 20.05/20.08 and 20.02 by adding the > suppress_file directive to libabigail.abignore file. This directive will > prevent loading mlx5 common symbols and no comparison will be performed. > > Signed-off-by: Ophir Munk <ophi...@mellanox.com> > --- > devtools/libabigail.abignore | 7 +++++++ > drivers/common/mlx5/mlx5_common.h | 3 +++ > drivers/common/mlx5/mlx5_devx_cmds.h | 23 +++++++++++++++++++++++ > drivers/common/mlx5/mlx5_nl.h | 18 +++++++++++++++++- > drivers/common/mlx5/rte_common_mlx5_version.map | 6 +++--- > 5 files changed, 53 insertions(+), 4 deletions(-) Can you add a Fixes: section. Referencing the original git commit that added the symbols we are ignoring? Ray K
- Re: [dpdk-dev] [PATCH v1 1/3] devtools: create inter... Ray Kinsella
- Re: [dpdk-dev] [PATCH v1 1/3] devtools: create inter... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v1 1/3] devtools: create i... David Marchand
- Re: [dpdk-dev] [PATCH v1 1/3] devtools: crea... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v1 1/3] devtools: ... Ray Kinsella
- Re: [dpdk-dev] [PATCH v1 1/3] devto... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v1 1/3] d... Ophir Munk
- [dpdk-dev] [PATCH v2 0/2] add INTERNAL tags and avoid com... Ophir Munk
- [dpdk-dev] [PATCH v2 1/2] common/mlx5: add rte inter... Ophir Munk
- Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: add r... Matan Azrad
- Re: [dpdk-dev] [PATCH v2 1/2] common/mlx5: add r... Ray Kinsella
- [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte i... Ophir Munk
- [dpdk-dev] [PATCH v3 2/2] common/mlx5: remov... Ophir Munk
- Re: [dpdk-dev] [PATCH v3 1/2] common/mlx5: a... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v3 1/2] common/mlx... Ophir Munk
- Re: [dpdk-dev] [PATCH v3 1/2] commo... Thomas Monjalon
- Re: [dpdk-dev] [PATCH v3 1/2] c... Ophir Munk
- [dpdk-dev] [PATCH v4 1/2] common/mlx5: add r... Ophir Munk
- [dpdk-dev] [PATCH v4 2/2] common/mlx5: r... Ophir Munk
- Re: [dpdk-dev] [PATCH v4 1/2] common/mlx... Raslan Darawsheh