06/05/2020 14:42, David Marchand: > On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > > 05/05/2020 16:53, David Marchand: > > > On Tue, May 5, 2020 at 1:21 PM Ophir Munk <ophi...@mellanox.com> wrote: > > > > +; These functions were moved from stable to internal. > > > > +; This is a temporary exception till DPDK 20.11. > > > > > > This is not until 20.11 if we merge this patch now. > > > It is only when comparing 20.02 to 20.05. > > > After this, symbols will be marked INTERNAL and will be skipped by the > > > generic rule, so we can remove this exception in 20.08-rc0. > > > > I think we need to keep this rule until 20.11, > > because we want to ignore symbols which were in 19.11 and 20.02, > > and removed (as internal) in 20.05. > > Those symbols were exported in 20.02.
Right, no issue when comparing with 19.11. > Before this, they were internal to mlx5 net driver. > > > > > > If we remove this rule in 20.08, and comparing with 19.11, > > the tool will complain about removed symbols, isn't it? > > If we remove the rule in 20.08 and compare to _20.02_ then yes, we > would get an issue. > I was only thinking of comparing 20.08 with 20.05. > > We can keep this until 20.11 if you think it is safer. Yes I think we must make sure any comparison can be done during compatibility lifetime.
