Hi David / Pavan, I see this is already applied.
However, rte_cryptodev_queue_pair_setup() calls rte_cryptodev_sym_get_existing_header_session_size() The former is a stable API, the latter is experimental. So I expect the build to break when ALLOW_EXPERIMENTAL_API is disabled. I tried to build the crypto_perf tool to check this, wasn't clear where it gets it, seems like it inherits from here: mk/target/generic/rte.vars.mk. So I disabled it there and got many build errors. Am I missing something? How was this tested with the flag disabled? Fiona > -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of David Marchand > Sent: Tuesday, April 14, 2020 3:23 PM > To: dev <dev@dpdk.org> > Cc: Jerin Jacob <jerinjac...@gmail.com>; Pavan Nikhilesh > <pbhagavat...@marvell.com>; > Richardson, Bruce <bruce.richard...@intel.com>; Thomas Monjalon > <tho...@monjalon.net>; Yigit, > Ferruh <ferruh.yi...@intel.com>; Hemant Agrawal <hemant.agra...@nxp.com> > Subject: Re: [dpdk-dev] [PATCH v5] build: disable experimental API check > internally > > On Mon, Apr 13, 2020 at 4:56 PM David Marchand > <david.march...@redhat.com> wrote: > > > > From: Pavan Nikhilesh <pbhagavat...@marvell.com> > > > > Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and > > meson.build. Instead, enable ALLOW_EXPERIMENTAL_API flag across app, lib > > and drivers. > > This changes reduces the clutter across the project while still > > maintaining the functionality of ALLOW_EXPERIMENTAL_API i.e. warning > > external applications about experimental API usage. > > > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com> > > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com> > > Signed-off-by: David Marchand <david.march...@redhat.com> > > Applied. > > > -- > David Marchand
