On Fri, Apr 03, 2020 at 11:14:03AM +0200, David Marchand wrote: > On Fri, Apr 3, 2020 at 11:10 AM Bruce Richardson > <bruce.richard...@intel.com> wrote: > > > diff --git a/drivers/meson.build b/drivers/meson.build > > > index 987e616ae7..4d8f842ab8 100644 > > > --- a/drivers/meson.build > > > +++ b/drivers/meson.build > > > @@ -20,7 +20,7 @@ dpdk_driver_classes = ['common', > > > disabled_drivers = run_command(list_dir_globs, > > > get_option('disable_drivers'), > > > ).stdout().split() > > > > > > -default_cflags = machine_args > > > +default_cflags = machine_args + ['-DALLOW_EXPERIMENTAL_API'] > > > if cc.has_argument('-Wno-format-truncation') > > > default_cflags += '-Wno-format-truncation' > > > endif > > > > I see nothing wrong with that. > > > > Out of interest, is there a reason we don't just set it at the top level as > > a project c_arg, e.g. after setting "-include rte_config.h" in > > config/meson.build? > > As long as it is not inherited by examples and external apps, I am > fine with any simple solution :-). > It will be inherited by everything inside the current build, but building any examples separately or any external apps separately won't be affected.
/Bruce