Hello, David Marchand <david.march...@redhat.com> writes:
>> > + >> > LIBABIGAIL_REPO=${LIBABIGAIL_REPO:-https://sourceware.org/git/libabigail.git} >> > + LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} >> > + >> > + if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION" >> > ]; then >> > + rm -rf libabigail >> > + # if we change libabigail, invalidate existing abi cache >> > + rm -rf reference >> > + fi >> > + >> > + if [ ! -d libabigail ]; then >> > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_REPO >> > libabigail/src >> >> Why not using the tarball? >> http://mirrors.kernel.org/sourceware/libabigail/libabigail-1.6.tar.gz > > No good reason "now". > > I was first bitten by a reference to redhat-hardened-ld in some > libtool script in the tarball (/me looks in Dodji direction). > I then considered switching to different versions of libabigail by > just setting the LIBABIGAIL_VERSION env variable from .travis.yml. > I ended up with the current latest version which is also what is in > Ubuntu latest releases. I think either way (distro package, tarball and git) has some benefits and drawbacks. I think one benefit of /being able/ to use the code from git is for cases where you guys need some new features (and we tend to continuously add fixes/functionalities to the git repository) that is available in git only for now. Hopefully, with time, you'll only need to use the distro package. FWIW, I like the fact that your setup lets you choose between the distro package, the tarball or the git code. That's powerful. Cheers, -- Dodji