On Fri, Nov 8, 2019 at 12:05 PM David Marchand <david.march...@redhat.com> wrote: > > On Fri, Nov 8, 2019 at 11:21 AM <kka...@marvell.com> wrote: > > > > Hi David, > > > > Thanks for review, hopefully this patch will addresses most of the sutff. > > Rest I will address here. > > > > > > > > > + const char *procdir = "/proc/self/fd/"; > > > > > > self is a Linux thing. > > > This won't work on FreeBSD. > > > > IMHO original code didn't worked on FreeBSD as well. > > I have created function to adress in third patch > > Indeed... > > Well, wait. > Why do we need to close those file descriptors? > FreeBSD has been like this for quite some time.
We don't know what this is used for. We know it does not work on FreeBSD, but this does not seem to be a problem. Introducing something more on FreeBSD is a risk with no actual benefit at first sight. Either we take only the first patch under a #ifdef EXEC_ENV_LINUX or we leave this as is. Krzystof, is this a problem for you if we postpone and investigate further for 20.02? -- David Marchand
