On Fri, Nov 8, 2019 at 11:21 AM <kka...@marvell.com> wrote: > > Hi David, > > Thanks for review, hopefully this patch will addresses most of the sutff. > Rest I will address here. > > > > > > + const char *procdir = "/proc/self/fd/"; > > > > self is a Linux thing. > > This won't work on FreeBSD. > > IMHO original code didn't worked on FreeBSD as well. > I have created function to adress in third patch
Indeed... Well, wait. Why do we need to close those file descriptors? FreeBSD has been like this for quite some time. Can't we just remove this code? Maybe someone from Intel has an idea of why it was like this? Adding Bruce. -- David Marchand
