18/09/2019 15:32, Ray Kinsella: > this is cool, good work. > comments below. > > On 17/09/2019 08:57, Andrzej Ostruszka wrote: > > --- a/lib/librte_distributor/rte_distributor.c > > +++ b/lib/librte_distributor/rte_distributor.c > > @@ -32,7 +32,7 @@ EAL_REGISTER_TAILQ(rte_dist_burst_tailq) > > > > /**** Burst Packet APIs called by workers ****/ > > > > -void > > +void __vsym > > all these additional __vsym annotations looks like they belong in a > seperate patch, as they are fixing a bug and are not directly related to > adding LTO the build system.
Andrzej, you did not reply to this question. This is a real blocker for merging this series. Should __vsym addition be in a separate patch? Should we document its use in rte_function_versioning.h and versioning.rst? Please explain, thanks.
