On Fri, Oct 4, 2019 at 1:26 PM Nipun Gupta <nipun.gu...@nxp.com> wrote: > > IOVA_PHYS flag is not required in the DPAA config, thus disable it. > Also, disable the 1588 timer support by default on DPAA2 platform > due to the performance impact
With this patch, we don't have a single target using the 1588 timer support. This means that it will get broken in the future. Is this used? > > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com> With this patch, the meson configuration is unaligned with the make configuration. If I look before the patch: origin/master:config/meson.build:dpdk_conf.set('RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', true) origin/master:config/arm/meson.build: ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]] origin/master:config/common_base:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y origin/master:config/defconfig_arm64-dpaa2-linuxapp-gcc:CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=n And in the history, I understand: - option (with dpaa2 in the name) introduced and enabled for all - later, disabled for dpaa2 Does it mean the option can be removed? -- David Marchand