On Thu, 18 Jul 2019 15:36:45 +0100 Bruce Richardson <bruce.richard...@intel.com> wrote:
> On Thu, Jul 18, 2019 at 07:34:59AM -0700, Stephen Hemminger wrote: > > On Thu, 18 Jul 2019 09:31:11 +0100 > > Bruce Richardson <bruce.richard...@intel.com> wrote: > > > > > On Wed, Jul 17, 2019 at 05:48:21PM -0700, Stephen Hemminger wrote: > > > > In general, DPDK libraries to not print error messages to > > > > stdout because that is often redirected to /dev/null for daemons. > > > > This patch changes cfgfile library to use RTE_LOG with its > > > > own type. > > > > > > > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > > > > --- > > > > lib/librte_cfgfile/Makefile | 1 + > > > > lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++--------- > > > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > > > > > diff --git a/lib/librte_cfgfile/Makefile b/lib/librte_cfgfile/Makefile > > > > index d9512565e559..4fc711778699 100644 > > > > --- a/lib/librte_cfgfile/Makefile > > > > +++ b/lib/librte_cfgfile/Makefile > > > > @@ -11,6 +11,7 @@ LIB = librte_cfgfile.a > > > > CFLAGS += -O3 > > > > CFLAGS += $(WERROR_FLAGS) > > > > CFLAGS += -I$(SRCDIR)/../librte_eal/common/include > > > > +LDFLAGS += -lrte_log > > > > > > > Where does this come from, there is no separate log library in DPDK? > > > > I saw a build failure with previous patch about rte_log not being > > present. > > I can believe that, it's just how does this help? What does the linker pick > up when you pass this? Not sure what causes this: *Make Build Failed #1: OS: RHEL80-64 Target: x86_64-native-linuxapp-gcc+shared rte_cfgfile.o:rte_cfgfile.c:(.text.unlikely+0xbe): more undefined references to `rte_log' follow rte_cfgfile.o: In function `cfgfile_init': rte_cfgfile.c:(.text.startup+0xc): undefined reference to `rte_log_register' rte_cfgfile.c:(.text.startup+0x25): undefined reference to `rte_log_set_level' collect2: error: ld returned 1 exit status make[5]: *** [/tmp/RHEL80-64_K3.10.0_GCC8.2.1/x86_64-native-linuxapp-gcc+shared/6baa0548e7644f418e02f19043f86f82/dpdk/mk/rte.lib.mk:102: librte_cfgfile.so.2.1] Error 1 make[4]: *** [/tmp/RHEL80-64_K3.10.0_GCC8.2.1/x86_64-native-linuxapp-gcc+shared/6baa0548e7644f418e02f19043f86f82/dpdk/mk/rte.subdir.mk:37: librte_cfgfile] Error 2 make[4]: *** Waiting for unfinished jobs.... == Build lib/librte_eal/common SYMLINK-FILE include/rte_common.h SYMLINK-FILE include/rte_compat.h SYMLINK-FILE include/rte_branch_prediction.h --
