On Thu, 18 Jul 2019 15:36:45 +0100 Bruce Richardson <bruce.richard...@intel.com> wrote:
> On Thu, Jul 18, 2019 at 07:34:59AM -0700, Stephen Hemminger wrote: > > On Thu, 18 Jul 2019 09:31:11 +0100 > > Bruce Richardson <bruce.richard...@intel.com> wrote: > > > > > On Wed, Jul 17, 2019 at 05:48:21PM -0700, Stephen Hemminger wrote: > > > > In general, DPDK libraries to not print error messages to > > > > stdout because that is often redirected to /dev/null for daemons. > > > > This patch changes cfgfile library to use RTE_LOG with its > > > > own type. > > > > > > > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > > > > --- > > > > lib/librte_cfgfile/Makefile | 1 + > > > > lib/librte_cfgfile/rte_cfgfile.c | 38 +++++++++++++++++++++++--------- > > > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > > > > > diff --git a/lib/librte_cfgfile/Makefile b/lib/librte_cfgfile/Makefile > > > > index d9512565e559..4fc711778699 100644 > > > > --- a/lib/librte_cfgfile/Makefile > > > > +++ b/lib/librte_cfgfile/Makefile > > > > @@ -11,6 +11,7 @@ LIB = librte_cfgfile.a > > > > CFLAGS += -O3 > > > > CFLAGS += $(WERROR_FLAGS) > > > > CFLAGS += -I$(SRCDIR)/../librte_eal/common/include > > > > +LDFLAGS += -lrte_log > > > > > > > Where does this come from, there is no separate log library in DPDK? > > > > I saw a build failure with previous patch about rte_log not being > > present. > > I can believe that, it's just how does this help? What does the linker pick > up when you pass this? I don't think it helps, it was an ICC only error and it was purely a guess since I don't have ICC. Let me take it off in the next version and see what CI says.
