On Mon, Jul 01, 2019 at 04:57:30AM +0000, Slava Ovsiienko wrote:
> I think we should compromise: keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES
> and extend with runtime switch under this build-time option:
> 
> #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES
> if (record_tx)
>   .. gather tx related stats...
> if (record_rx)
>   .. gather rx related stats...
> #endif
> 
> This is very specific feature, it is needed while debugging and testing 
> datapath
> routines, and It seems this feature with appropriate overhead should not be 
> always enabled.
> existing build-time configuration options looks OK as for me. 
> 
> Bruce, if proposed runtime extension is acceptable - I will update the patch.
> 
Ok for me.

Thanks,
/Bruce

Reply via email to