On Wed, Jun 26, 2019 at 01:19:24PM +0000, Slava Ovsiienko wrote:
> Hi, Bruce
>
> Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #ifdef ?
>
> No, I did not try runtime control settings.
> Instead I compared performance with all RECORD_CORE_XX_CYCLES options
> enabled/disabled builds
> and have seen the ~1-2% performance difference on my setups (mainly fwd
> txonly with retry).
> So, ticks measuring is not free.
>
> With best regards,
> Slava
>
Yes, I realise that measuring ticks is going to have a performance impact.
However, what I was referring to was exactly the former - using an "if"
rather than an "ifdef". I would hope with ticks disable using this option
shows no perf impact, and we can reduce the use of build-time configs.
/Bruce
