Hi Erik,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Carrillo, Erik G
> Sent: Monday, June 10, 2019 8:26 PM
> To: Anoob Joseph <ano...@marvell.com>; Jerin Jacob Kollanukkaran
> <jer...@marvell.com>; Rao, Nikhil <nikhil....@intel.com>; Gujjar,
> Abhinandan S <abhinandan.guj...@intel.com>; Richardson, Bruce
> <bruce.richard...@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>
> Cc: Narayana Prasad Raju Athreya <pathr...@marvell.com>; dev@dpdk.org;
> Lukas Bartosik <lbarto...@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavat...@marvell.com>; Hemant Agrawal
> <hemant.agra...@nxp.com>; Nipun Gupta <nipun.gu...@nxp.com>; Van
> Haaren, Harry <harry.van.haa...@intel.com>; Mattias Rönnblom
> <mattias.ronnb...@ericsson.com>; Ma, Liang J <liang.j...@intel.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in
> eventmode
>
> External Email
>
> ----------------------------------------------------------------------
> > -----Original Message-----
> > From: Anoob Joseph <ano...@marvell.com>
> > Sent: Monday, June 3, 2019 12:32 PM
> > To: Jerin Jacob <jer...@marvell.com>; Rao, Nikhil
> > <nikhil....@intel.com>; Carrillo, Erik G <erik.g.carri...@intel.com>;
> > Gujjar, Abhinandan S <abhinandan.guj...@intel.com>; Richardson, Bruce
> > <bruce.richard...@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.gua...@intel.com>
> > Cc: Anoob Joseph <ano...@marvell.com>; Narayana Prasad
> > <pathr...@marvell.com>; dev@dpdk.org; Lukasz Bartosik
> > <lbarto...@marvell.com>; Pavan Nikhilesh <pbhagavat...@marvell.com>;
> > Hemant Agrawal <hemant.agra...@nxp.com>; Nipun Gupta
> > <nipun.gu...@nxp.com>; Van Haaren, Harry
> <harry.van.haa...@intel.com>;
> > Mattias Rönnblom <mattias.ronnb...@ericsson.com>; Ma, Liang J
> > <liang.j...@intel.com>
> > Subject: [PATCH 24/39] eventdev: add Rx adapter init in eventmode
> >
> > Adding rx adapter conf. The helper init routine would be initializing
> > the rx adapter according to the conf.
> >
> > Signed-off-by: Anoob Joseph <ano...@marvell.com>
> > Signed-off-by: Lukasz Bartosik <lbarto...@marvell.com>
> > ---
>
> <...Snipped...>
>
> > diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h
> > b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> > index 2a6cd90..9c68605 100644
> > --- a/lib/librte_eventdev/rte_eventmode_helper_internal.h
> > +++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> > @@ -35,6 +35,12 @@
> > /* Max event devices supported */
> > #define EVENT_MODE_MAX_EVENT_DEVS RTE_EVENT_MAX_DEVS
> >
> > +/* Max Rx adapters supported */
> > +#define EVENT_MODE_MAX_RX_ADAPTERS RTE_EVENT_MAX_DEVS
> > +
> > +/* Max Rx adapter connections */
> > +#define EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER 16
> > +
> > /* Max event queues supported per event device */ #define
> > EVENT_MODE_MAX_EVENT_QUEUES_PER_DEV
> > RTE_EVENT_MAX_QUEUES_PER_DEV
> >
> > @@ -50,12 +56,33 @@ struct eventdev_params {
> > uint8_t ev_queue_mode;
> > };
> >
>
> Should the struct below be named "rx_adapter_connection_info" since you
> add "tx_adapter_connection_info" in a later patch?
[Anoob] Yes. Will make this change in v2.
>
> > +/* Rx adapter connection info */
> > +struct adapter_connection_info {
> > + uint8_t ethdev_id;
> > + uint8_t eventq_id;
> > + int32_t ethdev_rx_qid;
> > +};
> > +
> > +/* Rx adapter conf */
> > +struct rx_adapter_conf {
> > + int32_t eventdev_id;
> > + int32_t adapter_id;
> > + uint32_t rx_core_id;
> > + uint8_t nb_connections;
> > + struct adapter_connection_info
> > +
> > conn[EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER];
> > +};
> > +
>
> <...Snipped...>
>
> Regards,
> Erik
