> -----Original Message----- > From: Anoob Joseph <ano...@marvell.com> > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran <jer...@marvell.com>; Nikhil Rao > <nikhil....@intel.com>; Erik Gabriel Carrillo <erik.g.carri...@intel.com>; > Abhinandan Gujjar <abhinandan.guj...@intel.com>; Bruce Richardson > <bruce.richard...@intel.com>; Pablo de Lara > <pablo.de.lara.gua...@intel.com> > Cc: Anoob Joseph <ano...@marvell.com>; Narayana Prasad Raju Athreya > <pathr...@marvell.com>; dev@dpdk.org; Lukas Bartosik > <lbarto...@marvell.com>; Pavan Nikhilesh Bhagavatula > <pbhagavat...@marvell.com>; Hemant Agrawal > <hemant.agra...@nxp.com>; Nipun Gupta <nipun.gu...@nxp.com>; Harry > van Haaren <harry.van.haa...@intel.com>; Mattias Rönnblom > <mattias.ronnb...@ericsson.com>; Liang Ma <liang.j...@intel.com> > Subject: [PATCH 16/39] eventdev: add eventmode CL options framework > > Adding usage prints and CL parsing routines for eventmode. Option to select > packet transfer mode is also added. > > Signed-off-by: Anoob Joseph <ano...@marvell.com> > Signed-off-by: Lukasz Bartosik <lbarto...@marvell.com> > --- > +#include <rte_compat.h> > + > +/* Packet transfer mode of the application */ enum > +rte_eventmode_helper_pkt_transfer_mode { > + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL = 0, > + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_EVENT, > +};
Need to mark all public structues as EXPERIMENTAL. Please grep for EXPERIMENTAL in libeventdev or any other library > +struct rte_eventmode_helper_conf { > + enum rte_eventmode_helper_pkt_transfer_mode mode; > + /**< Packet transfer mode of the application */ > + void *mode_params; > + /**< Mode specific parameters */ > +}; Please make this event_helper object as 'opaque' and move to internal so that it does have ABI policies and future new features can be added.