> -----Original Message-----
> From: Anoob Joseph <ano...@marvell.com>
> Sent: Monday, June 3, 2019 11:02 PM
> To: Jerin Jacob Kollanukkaran <jer...@marvell.com>; Nikhil Rao
> <nikhil....@intel.com>; Erik Gabriel Carrillo <erik.g.carri...@intel.com>;
> Abhinandan Gujjar <abhinandan.guj...@intel.com>; Bruce Richardson
> <bruce.richard...@intel.com>; Pablo de Lara
> <pablo.de.lara.gua...@intel.com>
> Cc: Anoob Joseph <ano...@marvell.com>; Narayana Prasad Raju Athreya
> <pathr...@marvell.com>; dev@dpdk.org; Lukas Bartosik
> <lbarto...@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavat...@marvell.com>; Hemant Agrawal
> <hemant.agra...@nxp.com>; Nipun Gupta <nipun.gu...@nxp.com>; Harry
> van Haaren <harry.van.haa...@intel.com>; Mattias Rönnblom
> <mattias.ronnb...@ericsson.com>; Liang Ma <liang.j...@intel.com>
> Subject: [PATCH 14/39] eventdev: add files for eventmode helper
>
> Adding files for eventmode helper
>
> Signed-off-by: Anoob Joseph <ano...@marvell.com>
> Signed-off-by: Lukasz Bartosik <lbarto...@marvell.com>
> ---
> lib/librte_eventdev/Makefile | 5 +++--
> lib/librte_eventdev/meson.build | 2 ++
> lib/librte_eventdev/rte_eventmode_helper.c | 7 +++++++
> lib/librte_eventdev/rte_eventmode_helper.h | 15 +++++++++++++++
s/rte_eventmode_helper/rte_event_helper/gc. See below
> lib/librte_eventdev/rte_eventmode_helper_internal.h | 6 ++++++
> 5 files changed, 33 insertions(+), 2 deletions(-) create mode 100644
> lib/librte_eventdev/rte_eventmode_helper.c
> +#ifndef _RTE_EVENTMODE_HELPER_H_
> +#define _RTE_EVENTMODE_HELPER_H_
In order to shortened the macros, enums, APIs, I think,
We can change to rte_event_helper from rte_eventmode_here.
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_EVENTMODE_HELPER_H_ */
> diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h
> b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> new file mode 100644
> index 0000000..0da7003
> --- /dev/null
> +++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> @@ -0,0 +1,6 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright (C) 2019 Marvell International Ltd.
> + */
> +#ifndef _RTE_EVENTMODE_HELPER_INTERNAL_H_ #define
Please have this patch for Helper API definition(spec) and remaining patches
for implementation. That would help contract between helper and application.
> +_RTE_EVENTMODE_HELPER_INTERNAL_H_
> +#endif /* _RTE_EVENTMODE_HELPER_INTERNAL_H_ */
> --
> 2.7.4
