Hi Ferruh,
some minor bash improvements that could be made in the next revision:
On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> diff --git a/scripts/merge_maps.sh b/scripts/merge_maps.sh
> new file mode 100755
> index 0000000..bc40dc8
> --- /dev/null
> +++ b/scripts/merge_maps.sh
> @@ -0,0 +1,29 @@
> +#!/bin/sh
> +
> +FILES=$(find $RTE_SDK -name "*.map" | grep -v build)
> +SYMBOLS=$(grep -h "{" $FILES | sort -u | sed 's/{//')
Guarding $RTE_SDK and $FILES with "" will help avoid some potential
issues due to words splitting.
[...]
> + sed -n "/$s {/,/}/p" $f | sed '/^$/d' | grep -v global | grep
> -v local | sed '1d' | sed '$d'
As above with $f
[...]
> + if [ "$prev_sym" == "none" ]; then
Should be only one = as == is non standard and could fail in some environments.
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
