> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Herakliusz Lipiec > Sent: Tuesday, April 23, 2019 7:43 PM > Cc: dev@dpdk.org; Lipiec, Herakliusz <herakliusz.lip...@intel.com>; Zhang, > Qi Z <qi.z.zh...@intel.com>; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak > > When sending synchronous IPC requests, the caller must free the response > buffer even if the request returned failure. Fix the code to correctly > use the IPC API. > > Bugzilla ID: 228 > Fixes: ac9e4a17370f ("eal: support attach/detach shared device from > secondary") > Cc: qi.z.zh...@intel.com > Cc: sta...@dpdk.org > Signed-off-by: Herakliusz Lipiec <herakliusz.lip...@intel.com> > ---
Shouldn't the commit title be something like "hotplug: fix ipc memleak"? Or even more specifically "hotplug: fix memleak on ipc failure". For the patch itself: Reviewed-by: Darek Stojaczyk <dariusz.stojac...@intel.com>