> -----Original Message-----
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, April 1, 2019 1:06 AM
> To: Zhang, Qi Z <qi.z.zh...@intel.com>
> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell...@intel.com>;
> Yigit, Ferruh <ferruh.yi...@intel.com>; O'Hare, Cathal
> <cathal.oh...@intel.com>;
> Mcnamara, John <john.mcnam...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 00/38] ice share code update.
>
> 25/03/2019 08:07, Zhang, Qi Z:
> > > Sync to latest kernel driver, main changes:
> > > 1. add DCB/FDIR support.
> > > 2. add more APIs in switch module.
> > > 3. code clean and bug fix.
> > >
> > > Qi Zhang (38):
> > > net/ice/base: add switch resource allocation and free
> > > net/ice/base: improve comments
> > > net/ice/base: add two helper functions
> > > net/ice/base: add helper macros
> > > net/ice/base: allow package copy to be used after resets
> > > net/ice/base: clean code
> > > net/ice/base: declare functions as external
> > > net/ice/base: add more APIs in switch module
> > > net/ice/base: add VSI queue context framework
> > > net/ice/base: add APIs to add remove ethertype filter
> > > net/ice/base: add APIs to get allocated resources
> > > net/ice/base: add APIs to alloc/free resource counter
> > > net/ice/base: add APIs to get VSI promiscuous mode
> > > net/ice/base: add MAC filter with marker and counter
> > > net/ice/base: add two helper functions for flow management
> > > net/ice/base: fix minor issues
> > > net/ice/base: update macros
> > > net/ice/base: clean code
> > > net/ice/base: enable VSI queue context
> > > net/ice/base: ensure only valid bits are set
> > > net/ice/base: enhance get link status command
> > > net/ice/base: add RSS key related macro and structures
> > > net/ice/base: do not write TCAM entries back
> > > net/ice/base: remove local VSIG allocations
> > > net/ice/base: fix minor issues
> > > net/ice/base: update copyright time
> > > net/ice/base: fix Klockwork analysis reported issues
> > > net/ice/base: return config error without queue to disable
> > > net/ice/base: add function to check FW recovery mode
> > > net/ice/base: change profile id reference counting
> > > net/ice/base: add DCB support
> > > net/ice/base: add FDIR support
> > > net/ice/base: change profile priority for RSS reply
> > > net/ice/base: fix duplicate resource allocations
> > > net/ice/base: fix minor issues
> > > net/ice/base: increase prototol offset size
> > > net/ice/base: revert the workaround for resource allocation
> > > net/ice/base: rework on bit ops
> >
> > Applied to dpdk-next-net-intel.
> >
> > Thanks
> > Qi
>
> 3 commits have the title "fix minor issues", that's a funny performance.
> When the ice PMD will enter in a serious phase, you should write some real
> commit titles and explain what are the fixed issues.
> For DPDK 19.05, I guess it's fine because ice PMD is not going to be really
> used
> soon, right?
Yes, the share code in 19.05 can be regarded as an initial version, the commit
log is not quite sensitive for developers.
Thanks to forgive this rough, this will not happen in our following share code
update :)
>
