26/12/2018 06:21, Varghese, Vipin: > HI Thomas, > > Snipped > > > > > Small nits > > > > 9th patch in this set is doc. So above info need to be corrected. > > > > if you are addressing my earlier comment of separating out mempool > > > > element iteration changes in to separate new patch 9/10 .Please keep > > > > my ack in next version > > > > > > Thanks for pointing this out, Like updated in email and chat I am not > > planning to split it. Hence no version 8. > > > > So, no ack and no merge? > > > > Looking at the first patches + doc patch, the split is not meaningful. > > You should merge doc and option parsing in the related patches. > > For instance, parsing and doc of "tm" option should be in the "tm" patch. > > I did not follow you request. Are you stating, for each functionality I > should be updating document rather than 1 document update after adding the > new functions? If former is true I am not able to find such reasoning stated > in guideline or documentation or from the maintainer.
Yes, you should update the doc while adding a new feature. But most importantly, there is no reason to do a patch adding some empty functions and filling them later. And please consider the option parsing is part of the feature.
