10/01/2019 09:53, Varghese, Vipin: > Hi Thomas, > > snipped > > > > 10/01/2019 04:08, Varghese, Vipin: > > > snipped > > > > > > > > Hi Vipin, > > > > > > > > The code split in this v8 looks really better, except this patch > > > > which makes no sense alone. > > > Hi Thomas, I need this base patch as first one. These include the helper > > MACRO and include which pans out for next 7 patches. > > > > > > > I feel you can move these changes in next patches, where appropriate, > > > > isn't > > it? > > > Patches v2 to v7 uses common features from v1. > > > > At least, you should introduce the includes when needed. > As mentioned earlier these are used in v2 to v7.
So? They must be introduced first time they are used. Vipin, please be cooperative. > > If you need this patch for introducing some macros, then rename it and > > explain the macros in the message. > The MACRO introduced in this patch are 'MAX_STRING_LEN, STATS_BDR_FMT and > STATS_BDR_STR'. As per code contribution guideline I may have missed out the > stipulation requesting for explaining the same. > > > > > > > > > 07/01/2019 16:38, Vipin Varghese: > > > > > Update code base and meson build file to accommodate changes for > > > > > the new functionality. > > > > > > > > > > Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com> > > > > > Acked-by: Reshma Pattan <reshma.pat...@intel.com> > > > > > --- > snipped >
