> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, December 14, 2018 10:43 AM
> To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.y...@intel.com>; Li, Xiaoyun
> <xiaoyun...@intel.com>; Wu, Jingjing <jingjing...@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update
>
>
>
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Friday, December 14, 2018 8:36 AM
> > To: Zhang, Qi Z <qi.z.zh...@intel.com>; dev@dpdk.org
> > Cc: Yang, Qiming <qiming.y...@intel.com>; Li, Xiaoyun
> > <xiaoyun...@intel.com>; Wu, Jingjing <jingjing...@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update
> >
> > Hi Qi,
> >
> > > -----Original Message-----
> > > From: Zhang, Qi Z
> > > Sent: Thursday, December 13, 2018 4:47 PM
> > > To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org
> > > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming
> > > <qiming.y...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>; Wu,
> > > Jingjing <jingjing...@intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link
> > > update
> > >
> > > Hi Wenzhuo:
> > >
> > > > -----Original Message-----
> > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu
> > > > Sent: Wednesday, December 12, 2018 3:00 PM
> > > > To: dev@dpdk.org
> > > > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming
> > > > <qiming.y...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>; Wu,
> > > > Jingjing <jingjing...@intel.com>
> > > > Subject: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update
> > > >
> > > > Add ops link_update.
> > >
> > >
> > > > +ice_interrupt_handler(void *param) {
> > > > + struct rte_eth_dev *dev = (struct rte_eth_dev *)param;
> > > > + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data-
> > > >dev_private);
> > > > + uint32_t oicr;
> > >
> > > I saw the patch also enabled interrupt handler, which looks like be
> > > independent and not related with the commit log.
> > > It's better to separate it.
> > Here we only enable LSC interrupt for link update. So, I prefer
> > putting it in this patch.
>
> OK, I will suggest to modify the commit log to include the LSC part, since
> enable LSC is different with add ops link_update.
Will add it in the log.
