Hi Wenzhuo: > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, December 12, 2018 3:00 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Yang, Qiming > <qiming.y...@intel.com>; Li, Xiaoyun <xiaoyun...@intel.com>; Wu, Jingjing > <jingjing...@intel.com> > Subject: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > Add ops link_update.
> +ice_interrupt_handler(void *param) > +{ > + struct rte_eth_dev *dev = (struct rte_eth_dev *)param; > + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + uint32_t oicr; I saw the patch also enabled interrupt handler, which looks like be independent and not related with the commit log. It's better to separate it.