Re: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

[Varghese, Vipin]

> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Thursday, December 6, 2018 11:29 AM
> To: Varghese, Vipin <vipin.vargh...@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
> 
> Hi Vipin,
> 
> 
> > -----Original Message-----
> > From: Varghese, Vipin
> > Sent: Thursday, December 6, 2018 12:31 PM
> > To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org
> > Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
> >
> > Hi Wenzhuo
> >
> > snipped
> > > >
> > > > Should not meson build option be add start. That is in patch 1/20
> > > > so compile options does not fail?
> > > It will not fail. Enabling the compile earlier only means the code
> > > can be
> > compiled.
> > > But, to use this device we do need the whole patch set. From this
> > > point of view, compiling it at the end maybe better.
> > Thanks for update, so will 'meson-build' success if apply 3 patches?
> Sure, meson build will not be broken by any one of these patches. Only until 
> this
> patch, what built by meson can support ice.
Thanks for confirmation that you have tried './devtools/test-meson-builds.sh' 
and the intermediate build for ICE_DSI PMD does not fail.

> 
> >
> > >
> > > >
> > > > Thanks
> > > > Vipin Varghese