Re: [dpdk-dev] [PATCH v2 14/20] net/ice: support statistics

[Lu, Wenzhuo]

Hi Vipin,


> -----Original Message-----
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:35 PM
> To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo...@intel.com>; Guo, Jia <jia....@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 14/20] net/ice: support statistics
> 
> snipped
> > +   ns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +
> > +                        ns->eth.tx_broadcast) * ETHER_CRC_LEN;
> 
> In earlier patch for 'mtu set check' we added VSI SWITCH VLAN. Should we
> add VSI VLAN here?
Don't need. They're different functions. We add crc length here because of HW 
counts the packet length before crc is added.


> snipped