Hi Vipin,
> -----Original Message----- > From: Varghese, Vipin > Sent: Monday, December 3, 2018 4:15 PM > To: Lu, Wenzhuo <wenzhuo...@intel.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo...@intel.com> > Subject: RE: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and > update release note > > Hi, > > Thanks for adding details for secondary multi process in limitations section, > even though the API were expected. > > > -----Original Message----- > > From: dev <dev-boun...@dpdk.org> On Behalf Of Wenzhuo Lu > > Sent: Monday, December 3, 2018 12:37 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo...@intel.com> > > Subject: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and > > update release note > > > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > > --- > > Do not we have to add change details like > > V2: > - updated the limitation sections > - removed section etc? Good suggestion, thanks. I can add that in the next version. > > Snipped > > > +[Features] > > +Speed capabilities = Y > > +Link status = Y > > +Link status event = Y > > +Rx interrupt = Y > > +Queue start/stop = Y > > +MTU update = Y > > +Jumbo frame = Y > > +Scattered Rx = Y > > +TSO = Y > > +Unicast MAC filter = Y > > +Multicast MAC filter = Y > > +RSS hash = Y > > +RSS key update = Y > > +RSS reta update = Y > > +VLAN filter = Y > > +CRC offload = Y > > +VLAN offload = Y > > +QinQ offload = Y > > +L3 checksum offload = Y > > +L4 checksum offload = Y > > +Packet type parsing = Y > > +Rx descriptor status = Y > > +Tx descriptor status = Y > > +Basic stats = Y > > +Extended stats = Y > > Do we support Traffic Manager and Inline Crypto? If not, can we add this > also to limitations? The style is only listed supported features here. I don't think we'll list everything not supported as limitation. The same below. > > > +FW version = Y > > +Module EEPROM dump = Y > > +Multiprocess aware = Y > > +BSD nic_uio = Y > > +Linux UIO = Y > > +Linux VFIO = Y > > +x86-32 = Y > > +x86-64 = Y > > Is cross compile for ARM and PPC disabled since it uses Intel specific ISA? > Should this be added to limitations? > > > Snipped > > > + > > +Config File Options > > +~~~~~~~~~~~~~~~~~~~ > > + > > +The following options can be modified in the ``config`` file. > > +Please note that enabling debugging options may affect system > performance. > > Do we see real performance variance? If yes, can we highlight this in info > section? IMH, we could get different numbers because of different scenarios. It's only a reminder to not enable debug. > > snipped