Hello Ferruh, On Fri, Sep 14, 2018 at 1:37 PM, Ferruh Yigit <ferruh.yi...@intel.com> wrote: > On 9/4/2018 11:02 AM, Shahaf Shuler wrote: >> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit: >>> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx >>> >>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. >>> Without any specific Rx offload flag, default behavior by PMDs is to >>> strip CRC. >>> >>> PMDs that support keeping CRC should advertise >>> DEV_RX_OFFLOAD_KEEP_CRC >>> Rx offload capability. >>> >>> Applications that require keeping CRC should check PMD capability first >>> and if it is supported can enable this feature by setting >>> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() >>> >>> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> >>> Acked-by: Tomasz Duszynski <t...@semihalf.com> >>> --- >>> v2: >>> * fix flag check >>> * add KEEP_CRC flag into "show port cap #" >>> >>> Note "show port cap #" and >>> "show port # [r/t]x_offload capabilities/configuration" >>> does same thing, in long term I suggest removing "show port cap" one >> >> >> Acked-by: Shahaf Shuler <shah...@mellanox.com> >> > > Applied to dpdk-next-net/master, thanks.
Should we have a little note about this api change in 18.11 release notes ? -- David Marchand
