> -----Original Message----- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, September 10, 2018 7:35 AM > To: Ferruh Yigit > Cc: Wenzhuo Lu; Jingjing Wu; Bernard Iremonger; John McNamara; Marko > Kovacevic; Qi Zhang; Xiao Wang; Neil Horman; Remy Horton; Ori Kam; Bruce > Richardson; Pablo de Lara; Radu Nicolau; Akhil Goyal; Tomasz Kantecki; John > W. Linville; Legacy, Allain; Peters, Matt; Ravi Kumar; Ajit Khaparde; Somnath > Kotur; Rahul Lakkireddy; Hemant Agrawal; Shreyansh Jain; John Daley; Hyong > Youb Kim; Gaetan Rivet; Beilei Xing; Konstantin Ananyev; Matan Azrad; > Shahaf Shuler; Yongseok Koh; Tomasz Duszynski; Dmitri Epshtein; Natalie > Samsonov; Stephen Hemminger; K. Y. Srinivasan; Haiyang Zhang; Alejandro > Lucero; Tetsuya Mukawa; Santosh Shukla; Rasesh Mody; Harish Patil; Shahed > Shaikh; Andrew Rybchenko; Jasvinder Singh; Cristian Dumitrescu; Jan Remes; > Keith Wiles; Maciej Czekaj; Maxime Coquelin; Tiwei Bie; Zhihong Wang; Yong > Wang; Amr Mokhtar; Declan Doherty; Chas Williams; David Hunt; Anatoly > Burakov; Harry van Haaren; Xiaoyun Li; Thomas Monjalon; dev@dpdk.org > Subject: Re: [PATCH v2] ethdev: make default behavior CRC strip on Rx > > -----Original Message----- > > > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > > Without any specific Rx offload flag, default behavior by PMDs is to > > strip CRC. > > > > PMDs that support keeping CRC should advertise > DEV_RX_OFFLOAD_KEEP_CRC > > Rx offload capability. > > > > Applications that require keeping CRC should check PMD capability > > first and if it is supported can enable this feature by setting > > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in > rte_eth_dev_configure() > > > > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Acked-by: Tomasz Duszynski <t...@semihalf.com> > > --- > > v2: > > * fix flag check > > * add KEEP_CRC flag into "show port cap #" > > > > Note "show port cap #" and > > "show port # [r/t]x_offload capabilities/configuration" > > does same thing, in long term I suggest removing "show port cap" one >
For AVP devices Acked-by: Allain Legacy <allain.leg...@windriver.com>
