Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, August 10, 2018 10:01 AM > To: Trahe, Fiona <fiona.tr...@intel.com> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; > Jozwiak, TomaszX > <tomaszx.jozw...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section > > 10/08/2018 09:51, Trahe, Fiona: > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 09/08/2018 18:50, Fiona Trahe: > > > > +Quick instructions for QAT compressdev PMD are as follows: > > > > > > > > +.. code-block:: console > > > > + > > > > + cd to the top-level DPDK directory > > > > + make defconfig > > > > + make > > > > > > This code block seems too much obvious. > > Just for completeness and to be helpful - save people wasting time looking > > for > > a non-existent QAT comp config option which they'd probably do if following > > the snippet above it > > for QAT crypto where there is a need to change config. > > I don't understand. > There is nothing to change in the config, right? [Fiona] Have a look in the final html - I believe it's clearer with this section in and is more helpful to leave in than to omit.
> > > > +.. _qat_kernel: > > > > + > > > > +Dependency on the QAT kernel driver > > > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > The anchor seems useless. > > > > > It's used a few paragraphs above. > > I don't find it in your patches. > It's in this patch about 40 lines above the line you commented on.
