Even after this fix we still have setups that use netvsc for example, on which testpmd exits with rte_panic right after loading it even without touching the KBD.
I recommend returning the previous prompt routine in test-pmd/cmdline.c and rework the SOFTNIC section there, preferably moving its poll section to use rte_service in a separate file cleaning the CLI files from PMD-specific implementation. > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 24, 2018 3:34 PM > To: Jasvinder Singh <jasvinder.si...@intel.com> > Cc: dev@dpdk.org; bernard.iremon...@intel.com; > reshma.pat...@intel.com; Mordechay Haimovsky <mo...@mellanox.com>; > olivier.m...@6wind.com; cristian.dumitre...@intel.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d > > Important note: > testpmd is currently really broken. > We cannot have a RC2 until it is fixed. > > > 24/07/2018 13:25, Thomas Monjalon: > > 23/07/2018 12:44, Jasvinder Singh: > > > Fix testpmd app exit by pressing ctrl+d, End-of-Transmission > > > character (EOT) on the empty command line. > > > > Please describe what is the issue and what is the cause. > > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > > > > > Reported-by: Mordechay Haimovsky <mo...@mellanox.com> > > > Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com> > > > --- > > > app/test-pmd/cmdline.c | 10 ++++++---- > > > lib/librte_cmdline/cmdline.c | 2 +- > > > > It is very suspicious to change the cmdline library. > > If there is a bug in this library, it deserves a separate fix. > >
