On 11-Jul-18 3:11 AM, Zhang, Qi Z wrote:
+/* Max length for a bus name */
+#define RTE_BUS_NAME_MAX_LEN 32

Is this enforced anywhere in the bus codebase? Can we guarantee that
bus name will never be bigger than this?

I think 32 should be enough for a bus name even in future.

Sorry, I missed your point, I think it is not enforced, we still can add a new 
bus exceed 32,
but for RTE_DEV_NAME_MAX_LEN which is used in rte_devargs to enforce all device 
name not exceed 64.
So, it's better to move RTE_BUS_NAME_MAX_LEN into hotplug_mp as internal , and 
this can be regarded as a limitation for hotplug so far, though it should be 
enough for all exist cases.
And same for RTE_DEV_ARGS_MAX_LEN.

Can we fix it in this patchset, or would that involve an ABI break of some sort?

--
Thanks,
Anatoly

Reply via email to