> -----Original Message----- > From: Burakov, Anatoly > Sent: Monday, July 9, 2018 10:38 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com>; tho...@monjalon.net > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org; > Richardson, Bruce <bruce.richard...@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com>; Shelton, Benjamin H > <benjamin.h.shel...@intel.com>; Vangati, Narender > <narender.vang...@intel.com> > Subject: Re: [PATCH v10 03/19] bus/pci: enable vfio unmap resource for > secondary > > On 09-Jul-18 4:36 AM, Qi Zhang wrote: > > Subroutine to unmap VFIO resource is shared by secondary and primary, > > and it does not work on the secondary process. > > The patch adds a dedicate function to handle the situation when a > > device is unmapped on a secondary process. > > > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> > > --- > > Hi Qi, > > Please correct me if i'm wrong here, but it seems like the unmapping code is > shared between primary and secondary, and the difference comes from > interrupts, bus mastering, and removing the device from tailq. Can we > separate out the common code somehow?
Yes, you are right and I will separate out the common code. Thanks Qi > > -- > Thanks, > Anatoly
