Hi Pablo >-----Original Message----- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 10 July 2018 03:54 >To: Verma, Shally <shally.ve...@cavium.com> >Cc: dev@dpdk.org; Athreya, Narayana Prasad ><narayanaprasad.athr...@cavium.com>; Murthy, Nidadavolu ><nidadavolu.mur...@cavium.com>; Sahu, Sunila <sunila.s...@cavium.com>; Gupta, >Ashish <ashish.gu...@cavium.com>; Kartha, >Umesh <umesh.kar...@cavium.com> >Subject: RE: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev > >External Email > >Hi Shally, > >A few minor comments: > >> -----Original Message----- >> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] >> Sent: Tuesday, July 3, 2018 4:24 PM >> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> >> Cc: dev@dpdk.org; pathr...@caviumnetworks.com; >> nmur...@caviumnetworks.com; Sunila Sahu >> <sunila.s...@caviumnetworks.com>; Ashish Gupta >> <ashish.gu...@caviumnetworks.com>; Umesh Kartha >> <umesh.kar...@caviumnetworks.com> >> Subject: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev >> > >Change title to: "cryptodev: add basic asymmetric structures"? >At least, don't use lib, and cryptodev twice.
So what's convention for all patches? Just cryptodev: <actual title> ? Thanks Shally > >> Add rte_crypto_asym.h with supported xfrms and associated op structures and >> APIs >> >> API currently supports: >> - RSA Encrypt, Decrypt, Sign and Verify >> - Modular Exponentiation and Inversion >> - DSA Sign and Verify >> - Deffie-hellman private key exchange > >Diffie-Hellman > >> - Deffie-hellman public key exchange >> - Deffie-hellman shared secret compute >> - Deffie-hellman public/private key pair generation using xform chain >> >> Signed-off-by: Shally Verma <shally.ve...@caviumnetworks.com> >> Signed-off-by: Sunila Sahu <sunila.s...@caviumnetworks.com> >> Signed-off-by: Ashish Gupta <ashish.gu...@caviumnetworks.com> >> Signed-off-by: Umesh Kartha <umesh.kar...@caviumnetworks.com> >
