> -----Original Message-----
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Tuesday, July 3, 2018 4:24 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> nmur...@caviumnetworks.com; Ashish Gupta
> <ashish.gu...@caviumnetworks.com>; Sunila Sahu
> <sunila.s...@caviumnetworks.com>; Umesh Kartha
> <umesh.kar...@caviumnetworks.com>
> Subject: [PATCH v4 3/4] lib/cryptodev: add asymmetric crypto capability in
> cryptodev
>
Remove "in cryptodev" from title, as it is redundant (and lib/).
> From: Ashish Gupta <ashish.gu...@caviumnetworks.com>
>
> Extend cryptodev with asymmetric capability APIs and definitions.
>
> Signed-off-by: Shally Verma <shally.ve...@caviumnetworks.com>
> Signed-off-by: Sunila Sahu <sunila.s...@caviumnetworks.com>
> Signed-off-by: Ashish Gupta <ashish.gu...@caviumnetworks.com>
> Signed-off-by: Umesh Kartha <umesh.kar...@caviumnetworks.com>
>
...
+++ b/lib/librte_cryptodev/rte_cryptodev.c
...
> + for (i = 1; i < RTE_DIM(rte_crypto_asym_xform_strings); i++) {
> + if (strcmp(xform_string,
> + rte_crypto_asym_xform_strings[i]) == 0) {
Add indentation here.
> + *xform_enum = (enum rte_crypto_asym_xform_type) i;
> + return 0;
> + }
> + }
> +
> + /* Invalid string */
> + return -1;
> +}
...
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
...
> /**
> + * Provide capabilities available for defined device and algorithm
> + *
> + * @param dev_id The identifier of the device.
> + * @param algo Description of crypto algorithms.
> + *
Build error on API docs:
lib/librte_cryptodev/rte_cryptodev.h:224: warning: argument 'algo' of command
@param is not found in the argument list of
rte_cryptodev_asym_capability_get(uint8_t dev_id,
const struct rte_cryptodev_asym_capability_idx *idx)
lib/librte_cryptodev/rte_cryptodev.h:234: warning: The following parameters of
rte_cryptodev_asym_capability_get(uint8_t dev_id, const struct
rte_cryptodev_asym_capability_idx *idx)
are not documented: parameter 'idx'
