Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Tuesday, July 3, 2018 4:24 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
> nmur...@caviumnetworks.com; Sunila Sahu
> <sunila.s...@caviumnetworks.com>; Ashish Gupta
> <ashish.gu...@caviumnetworks.com>; Umesh Kartha
> <umesh.kar...@caviumnetworks.com>
> Subject: [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev
> 
> Add rte_crypto_asym.h with supported xfrms and associated op structures and
> APIs

One more comment that I missed.

> +++ b/lib/librte_cryptodev/rte_crypto_asym.h

...

> +struct rte_crypto_rsa_op_param {

...

> +     rte_crypto_param sign;
> +     /**<
> +      * Pointer to RSA signature data. If operation is RSA
> +      * sign @ref RTE_CRYPTO_RSA_OP_SIGN, buffer will be
> +      * over-written with generated signature.

There is an error when building the API documentation here:

lib/librte_cryptodev/rte_crypto_asym.h:383: warning:
unable to resolve reference to `RTE_CRYPTO_RSA_OP_SIGN' for \ref command