kangpinghuang commented on a change in pull request #567: Add publish version 
task
URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662703
 
 

 ##########
 File path: be/src/olap/storage_engine.cpp
 ##########
 @@ -1002,4 +954,56 @@ OLAPStatus StorageEngine::load_header(
     return res;
 }
 
+
+OLAPStatus StorageEngine::execute_task(EngineTask* task) {
+    // 1. add wlock to related tablets
+    // 2. do prepare work
+    // 3. release wlock
+    {
+        vector<TabletInfo> tablet_infos;
+        task->get_related_tablets(&tablet_infos);
+        sort(tablet_infos.begin(), tablet_infos.end());
+        for (TabletInfo& tablet_info : tablet_infos) {
+            TabletSharedPtr tablet = 
TabletManager::instance()->get_tablet(tablet_info.tablet_id, 
tablet_info.schema_hash, false);
 
 Review comment:
   too long

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to