kangpinghuang commented on a change in pull request #536: Add Rowset and
RowsetBuilder for PushHandler
URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249659093
##########
File path: be/src/olap/push_handler.cpp
##########
@@ -54,10 +57,59 @@ OLAPStatus PushHandler::process_realtime_push(
OLAPStatus res = OLAP_SUCCESS;
_request = request;
- vector<TabletVars> tablet_infos(1);
- tablet_infos[0].tablet = tablet;
- AlterTabletType alter_tablet_type;
+ vector<TabletVars> tablet_vars(1);
+ tablet_vars[0].tablet = tablet;
+ res = _do_realtime_push(tablet, request, push_type, &tablet_vars,
tablet_info_vec);
+ // if transaction existed in engine but push not finished, not report to fe
+ if (res == OLAP_ERR_PUSH_TRANSACTION_ALREADY_EXIST) {
+ OLAP_LOG_WARNING("find transaction existed when realtime push, not
report. ",
Review comment:
OK, I will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
