kangpinghuang commented on a change in pull request #536: Add Rowset and
RowsetBuilder for PushHandler
URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249670514
##########
File path: be/src/olap/push_handler.cpp
##########
@@ -401,46 +394,42 @@ OLAPStatus PushHandler::_convert(
// Convert from raw to delta
VLOG(3) << "start to convert row file to delta.";
while (!reader->eof()) {
- if (OLAP_SUCCESS != (res = writer->attached_by(&row))) {
- OLAP_LOG_WARNING(
- "fail to attach row to writer. [res=%d tablet='%s'
read_rows=%u]",
- res, curr_tablet->full_name().c_str(), num_rows);
- break;
- }
-
- res = reader->next(&row, writer->mem_pool());
+ res = reader->next(&row, rowset_builder->mem_pool());
if (OLAP_SUCCESS != res) {
- OLAP_LOG_WARNING("read next row failed. [res=%d
read_rows=%u]",
- res, num_rows);
+ LOG(WARNING) << "read next row failed."
+ << " res=" << res
+ << " read_rows=" << num_rows;
break;
} else {
- writer->next(row);
+ if (OLAP_SUCCESS != (res = rowset_builder->add_row(&row)))
{
Review comment:
OK, I will fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
