Thank you Xuanwo -- I have filed an issue for this [1] as well as PRs to fix it [2][3].
Both of these are long standing issues, from what I can tell the sqlparser-rs repository never had a NOTICE file and the flamegraph.svg has been present in archives for 2 years -- these are not regressions in my ind Thus, I would like to request you change your vote to +1 for this RC to avoid having to restart the 3 day voting period. However, if you feel strongly, I will make another RC for consideration Andrew [1]: https://github.com/apache/datafusion-sqlparser-rs/issues/2495 [2]: https://github.com/apache/datafusion-sqlparser-rs/pull/2496 [3]: https://github.com/apache/datafusion-sqlparser-rs/pull/2497 On 2026/09/10 17:20:13 Xuanwo wrote: > -1 (non-binding) > > Thanks Andrew for preparing the release. > > I found two licensing-material issues in the source archive: > > 1. The archive has LICENSE.TXT but no NOTICE file. > 2. sqlparser_bench/img/flamegraph.svg embeds JavaScript from > Inferno, whose upstream license is CDDL 1.0. The archive > contains no corresponding license materials. > > I suggest excluding the generated flamegraph.svg from the > source release, and adding the missing NOTICE file before > cutting a new RC. > > Otherwise, SHA-256, SHA-512, the signature, and the complete > source comparison against v0.63.0-rc1 passed. On Linux x86_64, > the source build and all-features tests passed: 1,614 passed, > 0 failed, and 7 ignored. > > Thanks, > Xuanwo > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
