-1 (non-binding)

Thanks Andrew for preparing the release.

I found two licensing-material issues in the source archive:

1. The archive has LICENSE.TXT but no NOTICE file.
2. sqlparser_bench/img/flamegraph.svg embeds JavaScript from
   Inferno, whose upstream license is CDDL 1.0. The archive
   contains no corresponding license materials.

I suggest excluding the generated flamegraph.svg from the
source release, and adding the missing NOTICE file before
cutting a new RC.

Otherwise, SHA-256, SHA-512, the signature, and the complete
source comparison against v0.63.0-rc1 passed. On Linux x86_64,
the source build and all-features tests passed: 1,614 passed,
0 failed, and 7 ignored.

Thanks,
Xuanwo

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to