rootvector2 commented on PR #3691: URL: https://github.com/apache/cxf/pull/3691#issuecomment-6874082311
Sorry for the wait, pushed 2aede04. `isSecureRequest()` now checks `HttpServletRequest.isSecure()` first and only falls back to `REQUEST_URL`/`BASE_PATH` without a servlet request, with a case-insensitive scheme match. The `ENDPOINT_ADDRESS` fallback is gone. Cookies get `SameSite=Lax` by default and `setSameSite(null)` leaves it out. The tests assert the full `Set-Cookie` value and cover a TLS-terminating proxy, where the URL is `http` but the container reports secure. Javadoc is added on `isHttpOnlyCookie()`, `isSecureCookie()` and `isSecureRequest(Message)`, including that a null message is treated as not secure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
