rootvector2 opened a new pull request, #3691: URL: https://github.com/apache/cxf/pull/3691
`AbstractSSOSpHandler.createCookie` writes the `org.apache.cxf.websso.context` and `RelayState` cookies with only `Path`, `Domain` and `Expires`, so the key to the SP security context, and with it the SAML session, is readable by any script on the page and is also sent over plain HTTP, a gap the code flags with a TODO. Found while reviewing the JAX-RS SAML SSO cookie handling. The cookies now carry `HttpOnly` (`setHttpOnlyCookie(false)` opts out) and `Secure` when the request came in over HTTPS or `setSecureCookie(true)` is set, with `AbstractSSOSpHandlerTest` covering both attributes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
