rootvector2 commented on PR #3691: URL: https://github.com/apache/cxf/pull/3691#issuecomment-6874068045
Pushed 2aede040 covering all three. 1. `isSecureRequest()` now returns `HttpServletRequest.isSecure()` when `AbstractHTTPDestination.HTTP_REQUEST` is set, so a container configured for a TLS terminating proxy gets `Secure`. Without a servlet request it falls back on `REQUEST_URL` then `BASE_PATH` with a case-insensitive `regionMatches`, and the `ENDPOINT_ADDRESS` fallback is gone. 2. Cookies get `SameSite=Lax` by default, `setSameSite(String)` changes it and `null` leaves it out. The tests assert the full `Set-Cookie` value, including a `Domain;HttpOnly;Secure;SameSite=Strict` case. 3. Javadoc on `isHttpOnlyCookie()`, `isSecureCookie()`, the `SameSite` accessors and `isSecureRequest(Message)`, which states it returns `false` for a null message or an undetermined scheme. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
