reta commented on PR #2237: URL: https://github.com/apache/cxf/pull/2237#issuecomment-2623175395
Thanks @ppalaga > Wouldn't suffice to introduce the extension only if there comes somebody really needing the old behavior? I think we could indeed pick the new strategy as default but provide the fallback to the old one if users run into issues. > Hm... when thinking of it more, another possible solution strategy could be to pass the service name to GeneratedClassClassLoaderCapture, let it store per service and make WrapperClassLoader also load the classes through per-service class loaders... I think that would be more disruptive change since `GeneratedClassClassLoaderCapture` should be changed (yes, we could make it non-breaking but make it bloated). > And about the backward compatibility concerns, how about we maintain a cache in WrapperClassGenerator(or wherever more suitable), so if there's no conflict for the wrapper class names, we use the previous way to generate the package name, if we find the conflict to generate the same wrapper class in the same package(which didn't work previously), we use the new way to add SEI classname to generate the package name I think this would also work, thank you @ffang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
