reta commented on code in PR #2062:
URL: https://github.com/apache/cxf/pull/2062#discussion_r1757599380
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/OpenTelemetryStartInterceptor.java:
##########
@@ -51,5 +56,19 @@ public void handleMessage(Message message) throws Fault {
if (holder != null) {
message.getExchange().put(TRACE_SPAN, holder);
}
+
+ HttpServletRequest request =
(HttpServletRequest)message.getContextualProperty("HTTP.REQUEST");
+ if (request != null) {
+ Span.current().setAttribute(ClientAttributes.CLIENT_ADDRESS,
request.getRemoteAddr());
Review Comment:
Please use `holder.getScope().getSpan()`, there is no need to use
`Span.current()` - we know the exact span
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
