reta commented on code in PR #2062:
URL: https://github.com/apache/cxf/pull/2062#discussion_r1757604791
##########
integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/jaxrs/OpenTelemetryProvider.java:
##########
@@ -52,10 +59,24 @@ public OpenTelemetryProvider(final OpenTelemetry
openTelemetry, final Tracer tra
@Override
public void filter(final ContainerRequestContext requestContext) throws
IOException {
final TraceScopeHolder<TraceScope> holder =
super.startTraceSpan(requestContext.getHeaders(),
-
requestContext.getUriInfo()
-
.getRequestUri(),
+
requestContext.getUriInfo().getRequestUri(),
requestContext.getMethod());
+ Message message =
((ContainerRequestContextImpl)requestContext).getMessage();
+ HttpServletRequest request =
(HttpServletRequest)message.getContextualProperty("HTTP.REQUEST");
+ if (request != null) {
+ Span.current().setAttribute(ClientAttributes.CLIENT_ADDRESS,
request.getRemoteAddr());
Review Comment:
Please use `holder.getScope().getSpan()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
