csemaan1A commented on PR #2062:
URL: https://github.com/apache/cxf/pull/2062#issuecomment-2345462416

   > Thanks for the pull request, @csemaan1A ! I would suggest to preserve the 
span name (as you highlighted, it is breaking) to have consistent behavior 
across CXF tracing integrations, thank you.
   
   I renamed it to have only the path to be aligned with [the semantic 
convention of 
OpenTelemetry](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.35.0/specification/trace/api.md#span).
 
   
   Keep in mind, that the server span name [is set to 
path](https://github.com/apache/cxf/blob/main/integration/tracing/tracing-opentelemetry/src/main/java/org/apache/cxf/tracing/opentelemetry/AbstractOpenTelemetryProvider.java#L65),
 not the full URL.
   So what do you think? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to